fix: reduce UnboundMethod objects by memoizing initialize_parameters

[rainerborene]

I have just discovered a simple optimization on ViewComponent::Base that can reduce UnboundMethod objects allocation. I have removed other objects from this memory allocation report comparison to keep things simple and clear. These are the results in one of our main Rails endpoints.

Before:

allocated memory by class
-------------------------
4080  UnboundMethod

After:

allocated memory by class
-------------------------
1280  UnboundMethod

If you want to test this patch yourself, just do this on your ApplicationComponent:

class ApplicationComponent < ViewComponent::Base
  private
    def self.initialize_parameters
      @initialize_parameters ||= super
    end
end

[reeganviljoen]

@rainerborene can you please add your change to the changelog while waiting on a review

[Spone]

I'm a bit unsure if adding memorization here can have unwanted effects. Mind chiming in @camertron?

[camertron]

Cool, thanks for looking into this @rainerborene :)

The only issue I can think of would be if the #initialize method gets redefined via class_eval or something. It's possible in such a scenario that the memoized list of parameters would be out-of-date by the time Base tries to find the collection parameter. However I can't imagine that sort of thing is very common, so I think this change is ok 👍

[camertron]

I'm on leave right now @Spone, would you or another maintainer be able to look into the Vale CI failure and merge this?

[Spone]

Yes I will, thanks for your input!

[camertron]

I thought a bit more about this, and I'm now convinced the memoization probably won't affect detecting collection parameters. Any component that renders a collection should already have defined the collection parameter in its initializer. Virtually any monkeypatch or redefinition of the #initialize method will need to specify that argument as well, so there should be no danger in memoizing the argument list. There could still be a problem if .with_collection_parameter is called after memoization, which changes the name of the initialization parameter Base looks for. I think we can mitigate issues by setting @initialize_parameters to nil in .with_collection_parameter.