Add output_preamble to match postamble #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taking @camertron's suggestions Co-authored-by: Cameron Dutro <[email protected]>
|
Not sure what's going on with this PVC failure, will investigate. |
|
Ok, the failure is happening on PVC main too, so this PR shouldn't be blocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add output_preamble to match existing output_postamble, as suggested in this issue.
What approach did you choose and why?
To keep this PR as simple as possible, we've just mirrored the existing output_postamble code.
Anything you want to highlight for special attention from reviewers?
This is a follow-up to another PR, incorporating the changes suggested there.