Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default preview controller should not crash with config.action_controller.include_all_helpers = false #2045

Conversation

triskweline
Copy link
Contributor

As discussed in issue #1654.

… less generic

The default Rails configuration loads the PreviewHelper for every controller.
We should use specific method names to prevent name clashes with user-provided helpers.
@triskweline triskweline force-pushed the issue-1654-always-provide-view-source branch from 9ac2c87 to c0faca6 Compare June 14, 2024 11:33
@triskweline
Copy link
Contributor Author

This test fails for me on main (without my changes):

Failure:
RenderingTest#test_backtrace_returns_correct_file_and_line_number [test/sandbox/test/rendering_test.rb:566]:
Expected /app/components/exception_in_template_component.html.erb:2/ to match "/home/runner/work/view_component/view_component/vendor/bundle/ruby/3.4.0+0/bundler/gems/rails-a14eb2dc8475/railties/lib/rails/engine/route_set.rb:39:in 'method_missing'".

@reeganviljoen
Copy link
Collaborator

@triskweline this seems to be happening across the code basses, @joelhawksley It seems rails main has yet another breaking change, I will investigate it when I have some time

docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
docs/CHANGELOG.md Outdated Show resolved Hide resolved
@joelhawksley joelhawksley enabled auto-merge (squash) January 10, 2025 23:25
@joelhawksley joelhawksley merged commit eba4c14 into ViewComponent:main Jan 10, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants