Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 7 transscript #110

Closed
wants to merge 13 commits into from
Closed

Conversation

ClJarvis
Copy link
Contributor

Improve transcription Season 4 Episode 7

Description

This PR improves transcript Season 4 Episode 7 with Jessica Wilkins. Growing your tech career through writing.

Related Issue

Closes #52

@adiati98
Copy link
Contributor

Hey @ClJarvis,
Thanks for your PR!

You added there are two episodes files here.
Can you please remove the Season 3 Episode 9 as it's not related to this PR?

Thank you! :)

removed extra file
@ClJarvis
Copy link
Contributor Author

@adiati98 deleted file.

@adiati98
Copy link
Contributor

adiati98 commented Oct 23, 2023

@ClJarvis I see a conflicting files here. Please resolve it first :)
I think you should git pull the branch from your remote to your local, then push it back.

Try this:

checkout via command line

@adiati98
Copy link
Contributor

@ClJarvis it might be easier for you to copy paste the commands.

Click the "Use the command line" link in the conflicts box here. It will open the commands as my previous screenshot.

use the command line

Copy link
Contributor

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ClJarvis,

I found conversations without timestamps and without or not correct speakers.

There are also many typos. For example, the first letter after a period should be capitalized, "FreeCodeCamp" should be "freeCodeCamp", etc.

I haven't checked until the end. But please re-check everything and fix anything necessary.

@danieltott will update the transcripts on buzzsprout. So timestamps and speakers are very important here.

Thank you :)

191
00:09:29,957 --> 00:09:32,388
204
Bekah: same
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is no timestamp here?

00:09:31,005 --> 00:09:32,388
Dan: everyone did.

206
totally thought this was just
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also no timestamp here and the speaker here is Jessica.

@ClJarvis
Copy link
Contributor Author

@ClJarvis it might be easier for you to copy paste the commands.

Click the "Use the command line" link in the conflicts box here. It will open the commands as my previous screenshot.

use the command line

Where is the conflicts box?

@adiati98
Copy link
Contributor

@ClJarvis it might be easier for you to copy paste the commands.

Click the "Use the command line" link in the conflicts box here. It will open the commands as my previous screenshot.

use the command line

Where is the conflicts box?

You should see it when you scroll down. If you don't, you can refer to my other screenshot.

@ClJarvis
Copy link
Contributor Author

@ClJarvis it might be easier for you to copy paste the commands.
Click the "Use the command line" link in the conflicts box here. It will open the commands as my previous screenshot.
use the command line

Where is the conflicts box?

You should see it when you scroll down. If you don't, you can refer to my other screenshot.

Oh it's grayed out and disabled for me.

@adiati98
Copy link
Contributor

@ClJarvis it might be easier for you to copy paste the commands.
Click the "Use the command line" link in the conflicts box here. It will open the commands as my previous screenshot.
use the command line

Where is the conflicts box?

You should see it when you scroll down. If you don't, you can refer to my other screenshot.

Oh it's grayed out and disabled for me.

As I mentioned in the previous post, click the link that I highlighted.

@ClJarvis
Copy link
Contributor Author

Maybe I was unclear. That is grayed out and disabled for me. I do not have write access to it.

I removed the extra file. Made changes to 4_7 and submitted another PR.

conflicts

@adiati98
Copy link
Contributor

Thanks for the clarification, @ClJarvis!
I will close this PR as it's moved to #111. :)

@adiati98 adiati98 closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve episode transcription Season 4 Episode 7
2 participants