Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precession and memory fixes in DistRot for ReadOrbitData use #275

Merged
merged 12 commits into from
Mar 2, 2024

Conversation

deitrr
Copy link
Contributor

@deitrr deitrr commented Mar 1, 2024

Proposed changes

This fixes memory issues in DistRot when ReadOrbitData is used and adds the ability to force precession in that case.

Types of changes

What types of changes does your PR introduce to VPLanet?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change that fixes an issue)
  • [x ] New feature (non-breaking change that adds functionality)
  • New module (non-breaking change that adds a new module)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of the steps that are necessary before merging your PR.

  • I have added tests that prove my fix is effective or that my feature works
  • I have adhered to the Style or run the clang format code shown here
  • I have added necessary documentation (if appropriate)
  • I have run Valgrind on new tests to ensure no errors were found
  • (Optional) I have added an example showcasing the new change

Further comments

Sorry about any white space changes!

@RoryBarnes RoryBarnes merged commit 76f61f8 into VirtualPlanetaryLaboratory:main Mar 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants