use @Accessor over accesswidener and more static fields
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicBOMB
changed the title
@Accessor over accesswidener and more static fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 examples of mixin extras usage are in MinecraftVRMixin and OptionsVRMixin respectively.
Cleanup of OptionsVRMixin also revealed the keymapping category injection could be separated, so KeyMappingVRMixin was added and the accesswidener reduced.
This implementation benefits the VivecraftVRMod class greatly, as it no longer needs an INSTANCE field at all.
All fields may be initialized statically.
This may also avoid an injection priority conflict with fabric according to @fayer3 .