Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav bar user story 2 #46

Merged
merged 6 commits into from
Mar 21, 2019
Merged

Nav bar user story 2 #46

merged 6 commits into from
Mar 21, 2019

Conversation

milevy1
Copy link
Collaborator

@milevy1 milevy1 commented Mar 21, 2019

Adds navigation bar to the application.html.erb view so it renders on every page. It has links to root_path (welcome_page) and books_path. Passes requirements of user story 2.

Also added the welcome page view template and CSS styling for the welcome page.

Closes #30

@milevy1 milevy1 added the review label Mar 21, 2019
@Vjp888
Copy link
Owner

Vjp888 commented Mar 21, 2019

Thanks for adding those tests, covers all bases now.

I approve for merge.

@Vjp888 Vjp888 merged commit 9e3cdef into master Mar 21, 2019
@Vjp888 Vjp888 removed the review label Mar 21, 2019
@milevy1 milevy1 deleted the nav_bar_user_story_2 branch March 21, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants