fix: verifyTX on message attestation (#1218)

# Related Github tickets

- #1857

# Background

Get the valset ID from the message public access data, set by pigeon.
Paloma uses this public access data when verifying the TX and get the
same valset as pigeon.

- Add valsetID as new field, instead of packing it into the
PublicAccessData data. This makes it more explicit and less error prone.
- When attesting SLC and UpdateValset messages we now get the same
valset as pigeon (which it gets from compass), instead of the latest
version store in paloma.
- Update the SetPublicAccessData so pigeon can set the valset ID.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.

proto/palomachain/paloma/consensus/consensus_queue.proto

@@ -64,6 +64,7 @@ message PublicAccessData {
   bytes valAddress = 1 [ (gogoproto.casttype) =
                              "github.com/cosmos/cosmos-sdk/types.ValAddress" ];
   bytes data = 2;
+  uint64 valsetID = 3;
 }
 
 message ErrorData {

proto/palomachain/paloma/consensus/query.proto

@@ -103,6 +103,7 @@ message MessageWithSignatures {
   bytes publicAccessData = 6;
   bytes errorData = 7;
   repeated Evidence evidence = 8;
+  uint64 valsetID = 9;
 }
 
 message QueryMessageByIDRequest {

proto/palomachain/paloma/consensus/tx.proto

@@ -58,6 +58,7 @@ message MsgSetPublicAccessData {
   bytes data = 4;
   palomachain.paloma.valset.MsgMetadata metadata = 5
       [ (gogoproto.nullable) = false ];
+  uint64 valsetID = 6;
 }
 
 message MsgSetPublicAccessDataResponse {}

x/consensus/keeper/concensus_keeper.go

@@ -509,6 +509,7 @@ func (k Keeper) SetMessagePublicAccessData(
 	payload := &types.PublicAccessData{
 		ValAddress: valAddr,
 		Data:       msg.GetData(),
+		ValsetID:   msg.GetValsetID(),
 	}
 	err = cq.SetPublicAccessData(sdkCtx, msg.GetMessageID(), payload)
 	if err != nil {

x/consensus/keeper/consensus/consensus.go

@@ -473,9 +473,11 @@ func ToMessageWithSignatures(msg types.QueuedSignedMessageI, cdc codec.BinaryCod
 	}
 
 	var publicAccessData []byte
+	var valsetID uint64
 
 	if msg.GetPublicAccessData() != nil {
 		publicAccessData = msg.GetPublicAccessData().GetData()
+		valsetID = msg.GetPublicAccessData().GetValsetID()
 	}
 
 	var errorData []byte
@@ -491,6 +493,7 @@ func ToMessageWithSignatures(msg types.QueuedSignedMessageI, cdc codec.BinaryCod
 		BytesToSign:      msg.GetBytesToSign(),
 		SignData:         []*types.ValidatorSignature{},
 		PublicAccessData: publicAccessData,
+		ValsetID:         valsetID,
 		ErrorData:        errorData,
 	}
 	for _, signData := range msg.GetSignData() {