DCA bot pancakeswap audit #1
Conversation
| filters: | ||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
Note that this repo only has a main branch.
| [package] | ||
| name = "dca-bot-pancakeswap-cw" | ||
| version = "0.1.0" | ||
| authors = ["wc117"] |
|
|
||
| There is a view function in the smart contract that returns swappable id, minimal out amount, and remaining trade counts that can be swapped on Uniswap V2 or a DEX that works just like it. | ||
|
|
||
| A scheduler or script fetch the swappable id from the Vyper smart contract and run `swap` function with the id and minimal out amount. |
There was a problem hiding this comment.
s/fetch/fetches, s/run/runs
Not sure what "minimal out amount" means in context.
|
|
||
| Users can deposit their token or coin into a Vyper smart contract on EVM chain. | ||
|
|
||
| There is a view function in the smart contract that returns swappable id, minimal out amount, and remaining trade counts that can be swapped on Uniswap V2 or a DEX that works just like it. |
There was a problem hiding this comment.
If it is a function named view use backticks, otherwise name it here (and name these other things e.g.
returns swappable id (
swap_id)
There was a problem hiding this comment.
It feels like the entire artifacts/ directory should not be here, and should be in .gitignore.
| amount_out_min: Uint256, | ||
| number_trades: Uint256, | ||
| ) -> Result<Response<PalomaMsg>, ContractError> { | ||
| let state = STATE.load(deps.storage)?; |
There was a problem hiding this comment.
This can be loaded way down where it's used.
| // Add any other custom errors you like here. | ||
| // Look at https://docs.rs/thiserror/1.0.21/thiserror/ for details. |
There was a problem hiding this comment.
We can delete some of the boilerplate probably.
| number_trades.to_be_bytes().as_slice(), | ||
| ), | ||
| )? { | ||
| if timestamp.plus_seconds(retry_delay).lt(&env.block.time) { |
There was a problem hiding this comment.
The fact that this is a separate if seems like a bug.
No description provided.