Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIDCS-3321: Implement participant list toggle button, chat button, report issue button on mobile #95
base: develop
Are you sure you want to change the base?
VIDCS-3321: Implement participant list toggle button, chat button, report issue button on mobile #95
Changes from all commits
51ccfe9
817f02b
e161457
d1905e1
e0962ac
1fe7848
5ce1373
f967716
7e13973
3bcdebf
9bba753
662c16c
fc25f04
db56dc7
afd5b01
e0314a2
f62f6e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this is different from before
px-3
, will this change anything?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem to impact anything on desktop:
this is with
px-3
in comparison on desktop:but on mobile, switching to
pr-3
helps with the gaps:this is with

px-3
in comparison:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the right margin for the chat button? I think it's interfering with the flex layout. There's more padding on the right side versus the left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ChatButton
did not have any right margin but I added a little bit on the layout toggle so that it aligns a bit better.iPhone 14 Pro Max: