Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Search bug fixes #4673

Merged
merged 9 commits into from
Apr 11, 2024
Merged

fix: Search bug fixes #4673

merged 9 commits into from
Apr 11, 2024

Conversation

byronxu99
Copy link
Collaborator

@byronxu99 byronxu99 commented Dec 1, 2023 •
edited
Loading

  • add_new_feature function should correctly handle feature width and stride
  • fixed memory leak in selective branching metatask
  • use smart pointers over manual memory management
  • use VW::scope_exit to restore modified state

@jackgerrits jackgerrits merged commit 128fad3 into VowpalWabbit:master Apr 11, 2024
112 checks passed
@bassmang bassmang mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byronxu99 @jackgerrits @olgavrou