misc improvements for user config lookup #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make emails case insensitive - bump version of email library - change name used in email template
ben-z
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Lgtm after the comment!
might want to use https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword to auto-close issues?
| @@ -40,7 +40,7 @@ async def send_edit_link(email: Email, background_tasks: BackgroundTasks): | |||
| "We received your email address and will be sending you an edit" | |||
| " link shortly!" | |||
| ) | |||
| email_address = email.email_address | |||
| email_address = email.email_address.lower() | |||
There was a problem hiding this comment.
Might want to lower emails from the our data too?
There was a problem hiding this comment.
I think we end up doing that here:
user-config-lookup/app/utils.py
Line 28 in 0d87a91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8, #9, #10