Application updates for v6.1.2 release #67
Conversation
|
@dforbush2 thank you, I'll merge this shortly and we can look into what's going on with the MOST cases |
|
This PR is for merge once full directional spectra is working in all applications cases. It is not currently. |
kmruehl
changed the title
|
@dforbush2 what's the status of this PR? It's currently a draft |
|
@kmruehl will merge this PR using the updated SLX files from @dforbush2's fork once WEC-Sim/WEC-Sim#1332 is merged |
|
@dforbush2 what's the status here? Are there any other changes in this PR besides updating slx files with broken library links? |
akeeste
changed the title
|
Seems like this needs one more update for broken links with the main in our latest release. I made these changes and can push to this branch |
* try to update libraries again * fix simscapeinstrumentationlogging error --------- Co-authored-by: akeeste <[email protected]>
Adding one fix per commit
Listing broken library links for future reference.
The MOST simulation is failing checks as compared to logged data, and does not have any broken library links.
In all observed cases these errors were relatively small but larger than the specified tolerance. I suggest we merge now and revisit/revise these failing tests. I believe this could be the result of the initial optimization steps converging differently.