Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check for some load out values #8

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: null check for some load out values #8

merged 2 commits into from
Apr 18, 2024

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Players can ommit using ceratin parts of their inventory (i.e. only melee, no amp) this would mean that some values wouldn't be in the json input


Reproduction steps


Evidence/screenshot/link to line

This user doesn't have a primary or secondary equipped ingame
image

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? Yes
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Bug Fix

Players can ommit using ceratin parts of their inventory (i.e. only melee, no amp) this can mean that some values will be undefined
@SlayerOrnstein SlayerOrnstein requested a review from a team as a code owner April 18, 2024 18:52
@TobiTenno TobiTenno enabled auto-merge (squash) April 18, 2024 20:54
@TobiTenno TobiTenno merged commit 84a1409 into main Apr 18, 2024
8 checks passed
@TobiTenno TobiTenno deleted the inventory-fix branch April 18, 2024 20:54
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants