Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

46 fee splitter tests #47

Merged
merged 16 commits into from
Feb 5, 2024
Merged

46 fee splitter tests #47

merged 16 commits into from
Feb 5, 2024

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Jan 23, 2024

No description provided.

@gangov gangov self-assigned this Jan 23, 2024
@gangov gangov linked an issue Jan 23, 2024 that may be closed by this pull request
Fee-Splitter: tests #46
Closed
@gangov gangov marked this pull request as ready for review February 1, 2024 08:15
@gangov gangov requested a review from ueco-jb February 1, 2024 08:15
ueco-jb
ueco-jb reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out the biggest issues for now.

contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
packages/bindings-test/src/coreum_testing_deps.rs Outdated Show resolved Hide resolved
packages/bindings-test/src/coreum_testing_deps.rs Outdated Show resolved Hide resolved
@gangov gangov requested a review from ueco-jb February 1, 2024 19:47
ueco-jb
ueco-jb reviewed Feb 2, 2024
View reviewed changes
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
contracts/fee_splitter/src/testing.rs Outdated Show resolved Hide resolved
ueco-jb
ueco-jb reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there's no test that checks whether the cw20 implementation is correct.

@gangov gangov requested a review from ueco-jb February 2, 2024 16:41
ueco-jb
ueco-jb approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the last comment, add testcase to cover that case (when the weights are less then 100%) and you can merge it.

contracts/fee_splitter/src/contract.rs Outdated Show resolved Hide resolved
@gangov gangov merged commit cc2f177 into main Feb 5, 2024
2 checks passed
@gangov gangov deleted the 46-fee-splitter-tests branch February 5, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

Assignees

@gangov gangov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fee-Splitter: tests
2 participants
@gangov @ueco-jb