[Spec] Network revocation patches for WebSocket and WebTransport APIs #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VergeA
reviewed
Jan 14, 2025
VergeA
reviewed
Jan 14, 2025
| In the intermediate state where {{Fence/disableUntrustedNetwork()}} has been called but the returned | ||
| {{Promise}} has not [=resolved=] yet, there are restrictions on features that involve making | ||
| requests over the network. The second algorithm below is used to determine whether those features | ||
| are allowed. |
There was a problem hiding this comment.
I think it might be good to mention that in this state, nested fenced frame trees may still have network access, and these restrictions will not apply to them until they also disable network. Hence why the algorithm below relies on the keyword "itself."
|
LGTM % 1 comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the following things happen for both
WebTransportandWebSocketobjects:Preview | Diff