Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update renderUrl -> renderURL capitalization #1381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update renderUrl -> renderURL capitalization #1381

wants to merge 1 commit into from

Conversation

lusayaa
Copy link
Contributor

@lusayaa lusayaa commented Jan 13, 2025

No description provided.

@rdgordon-index rdgordon-index mentioned this pull request Jan 13, 2025
Open
@JensenPaul
Copy link
Collaborator

Hmm the W3C spec seems to use lower case: https://wicg.github.io/turtledove/#build-trusted-key-value-scoring-signals-request-body
And Chrome's implementation also seems to use lower case: https://source.chromium.org/chromium/chromium/src/+/main:content/services/auction_worklet/trusted_signals_kvv2_helper.cc;l=53

@MattMenke2
Copy link
Contributor

Yea, we still send renderUrls over the wire (otherwise, we'd have to send each one twice to avoid breaking things). Looks like even in KVv2 we use renderUrls, likely inheriting behavior from KVv1.

@MattMenke2 MattMenke2 mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lusayaa @JensenPaul @MattMenke2