-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional slot-size parameters to trustedBiddingSignalsURL requests #928
Merged
+12
−8
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ce4855a
Add optional slot-size parameters to trustedBiddingSignalsURL requests
MattMenke2 ce59178
Update FLEDGE.md
MattMenke2 f229705
Update FLEDGE.md
MattMenke2 4eefec4
Update FLEDGE.md
MattMenke2 c9af021
Update FLEDGE.md
MattMenke2 5bdac81
Update FLEDGE.md
MattMenke2 dc11454
Update FLEDGE.md
MattMenke2 1a4d6ae
Update FLEDGE.md
MattMenke2 462c55d
Update FLEDGE.md
MattMenke2 6be6a4d
Update FLEDGE.md
MattMenke2 6197823
Update FLEDGE.md
MattMenke2 e0c924b
Merge branch 'WICG:main' into MattMenke2-slot-size
MattMenke2 edb343e
Update FLEDGE.md
MattMenke2 eeedda9
Update FLEDGE.md
MattMenke2 fa000ea
Update FLEDGE.md
MattMenke2 6f45465
Update FLEDGE.md
MattMenke2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
adSize
section indicates sw/sh are integer not decimal-valued:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly have no clue what they are. Are they percents as decimals? Percents as numbers? Fenced frame spec doesn't mention them at all. I don't know where to find this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So they're percents out of 100, and the 0.5 was wrong. Apparently that's how vw and vh work in CSS. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JensenPaul can you shed any light on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brought this to mind: They're both!.