Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel path outputs #347

Closed
wants to merge 2 commits into from
Closed

Rel path outputs #347

wants to merge 2 commits into from

Conversation

ptrbortolotti
Copy link
Collaborator

Purpose

When a relative path is provided in the analysis options for the output folder, the path starts from running directory, not where analysis options is located. This commit aligns WEIS to WISDEM, see https://github.com/WISDEM/WISDEM/blob/e0def101837ce0d677649846545ebdbc65ee433f/wisdem/glue_code/runWISDEM.py#L37. The need for this commit arose in an industrial collaboration where the partner runs WEIS on a HPC with no folder writing access

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@coveralls
Copy link

Coverage Status

coverage: 77.971% (-0.002%) from 77.973%
when pulling dbb9759 on rel_path_outputs
into a6b86b3 on develop.

@dzalkind
Copy link
Collaborator

I have a strong preference for making the output relative to the input file location and not the directory that WEIS is called from. WEIS can be called from anywhere, so it results in inconsistent output locations. Users can always specify an absolute path.

@ptrbortolotti
Copy link
Collaborator Author

Ah... I don't know that I like that relative paths start from the location of the analysis options yaml. In our shell code made for an industrial partner, the user won't even know where those files are. However I found out that the user was already asked to set an output folder, which was correctly passed to WISDEM but not to WEIS. I've therefore now solved my problem, and I can happily close this PR with no further action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants