Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TCP for multiplayer games #231

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

DanielHartl
Copy link
Contributor

UDP doesn't work or is hard to set up (if both parties are behind a NAT router). TCP support makes things much easier if there is a dedicated server with a public ip.

Caveat: this change breaks publishing games to metaserver. I think we should redefine the role of metaserver. Additionally to just enable discovery of newly hosted games it should actually start the dedicated server instances and register them with itself to allow clients to discover and connect to it.

@timfel
Copy link
Member

timfel commented Jun 28, 2018

Hi,
thanks for taking a look at this! Yes, the metaserver should try to make sure we can connect. The current approach tries to use NAT tunnelling through the metaserver to connect, but this often does not work. Indeed, a dedicated server running on the metaserver on a public IP/Port would make things easier. Feel free to experiment a bit and ping @mimooh, @Andrettin or me if you want to discuss a general overhaul of the networking code. I believe Wyrmgus didn't change too much in that area, either, so a more modern implementation of networked games would maybe benefit them too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants