Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial support for admins being allowed to perform host-only actions #4076

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

maxsupermanhd
Copy link
Member

@maxsupermanhd maxsupermanhd commented Sep 27, 2024

probably missing cleanup of NetPlay.isAdmin somewhere

Currently working:

  • enables admin gui when you join with identity that is promoted to room admin
  • allows swapping people around
  • allows changing color of players
  • allows changing team of players
  • announces all the relevant actions performed by admins

TODO:

  • make isAdmin dynamically change in response to admin add/remove on host (as well as identity swaps)
  • action announce announcing regular not admin requiring actions like changing color of self or changing own positions to empty ones
  • moving in/out of spec (needs to be allowed) (very cursed, needs big rework)
  • room settings like alliance/scav/power/base needs to be allowed (needs new netmessages)
  • room name change needs to be allowed (needs new netmessages)
  • some button to trigger host quit (must be with a double click / with some key pressed or with confirm dialogue)

@maxsupermanhd maxsupermanhd marked this pull request as ready for review October 6, 2024 17:49
@past-due past-due self-requested a review October 6, 2024 22:03
@KJeff01 KJeff01 added the PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Review Check if this PR is still relevant or needs minor tweaks to be ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants