Skip to content

Commit

Permalink
Upgraded outdated dependencies, updated publish workflow to create Di…
Browse files Browse the repository at this point in the history
…scussion with latest release notes. (#163)

* Upgraded outdated dependencies, updated publish workflow to create Discussion with latest release notes.

* Removed validate-input job as it is not needed from publish workflow.
  • Loading branch information
WasiqB authored Dec 27, 2021
1 parent 2118935 commit 8831a68
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 54 deletions.
38 changes: 14 additions & 24 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ on:
inputs:
release_type:
type: choice
description: 'Release Type'
description: "Release Type"
required: true
options:
- major
- minor
- patch
default: 'minor'
default: "minor"

env:
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
Expand All @@ -20,18 +20,7 @@ env:
NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }}

jobs:
validate-input:
runs-on: ubuntu-latest
if: ${{ github.event.inputs.release_type == 'major' ||
github.event.inputs.release_type == 'minor' ||
github.event.inputs.release_type == 'patch' }}
steps:
- name: Release Type selected for making release
run: echo "[${{ github.event.inputs.release_type }}] release in progress."

prepare-release-snapshot:
needs:
- validate-input
runs-on: ubuntu-latest
steps:
- name: Check out Git repository
Expand All @@ -40,8 +29,8 @@ jobs:
- name: Install Java and Maven
uses: actions/setup-java@v2
with:
java-version: '15'
distribution: 'adopt'
java-version: "15"
distribution: "adopt"

- name: Restore local Maven repository
uses: actions/cache@v2
Expand Down Expand Up @@ -83,8 +72,8 @@ jobs:
- name: Install Java and Maven
uses: actions/setup-java@v2
with:
java-version: '15'
distribution: 'adopt'
java-version: "15"
distribution: "adopt"

- name: Restore local Maven repository
uses: actions/cache@v2
Expand Down Expand Up @@ -119,8 +108,8 @@ jobs:
- name: Install Java and Maven
uses: actions/setup-java@v2
with:
java-version: '15'
distribution: 'adopt'
java-version: "15"
distribution: "adopt"

- name: Restore local Maven repository
uses: actions/cache@v2
Expand Down Expand Up @@ -167,8 +156,8 @@ jobs:
- name: Install Java and Maven
uses: actions/setup-java@v2
with:
java-version: '15'
distribution: 'adopt'
java-version: "15"
distribution: "adopt"

- name: Restore local Maven repository
uses: actions/cache@v2
Expand Down Expand Up @@ -205,8 +194,8 @@ jobs:
- name: Install Java and Maven
uses: actions/setup-java@v2
with:
java-version: '15'
distribution: 'adopt'
java-version: "15"
distribution: "adopt"

- name: Download target folder
uses: actions/download-artifact@v2
Expand Down Expand Up @@ -289,8 +278,9 @@ jobs:
tag_name: v${{ needs.push-pom.outputs.release-version }}
name: Version ${{ needs.push-pom.outputs.release-version }}
prerelease: false
generate_release_notes: true
draft: false
discussion_category_name: Announcements
generate_release_notes: true
files: |
target/*.jar
target/*.pom
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
/.classpath
/.project

# VS Code
/.vscode

# Other output folders
/target/
/bin/
Expand Down
5 changes: 0 additions & 5 deletions changelogs/CHANGELOG.md

This file was deleted.

15 changes: 0 additions & 15 deletions changelogs/latest.md

This file was deleted.

16 changes: 8 additions & 8 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<parent>
<groupId>com.github.wasiqb.coteafs</groupId>
<artifactId>parent</artifactId>
<version>3.6.4</version>
<version>3.8.0</version>
</parent>

<scm>
Expand All @@ -20,23 +20,23 @@
</scm>

<ciManagement>
<system>Circle CI</system>
<url>https://circleci.com/gh/WasiqB/coteafs-selenium</url>
<system>GitHub Actions</system>
<url>https://github.com/WasiqB/coteafs-selenium/actions</url>
</ciManagement>

<properties>
<coteafs.data.version>1.3.0</coteafs.data.version>
<coteafs.data.version>1.4.0</coteafs.data.version>
<coteafs.error.version>1.15.0</coteafs.error.version>
<log4j.version>2.17.0</log4j.version>
<coteafs.listener.version>3.2.0</coteafs.listener.version>
<coteafs.listener.version>3.3.0</coteafs.listener.version>
<selenium-version>3.141.59</selenium-version>
<commons.io.version>2.11.0</commons.io.version>
<webdrivermanager-version>4.4.3</webdrivermanager-version>
<webdrivermanager-version>5.0.3</webdrivermanager-version>
<faker.version>1.0.2</faker.version>
<commons.text.version>1.9</commons.text.version>
<recorder.version>0.7.7.0</recorder.version>
<lombok.version>1.18.20</lombok.version>
<jackson.version>2.12.4</jackson.version>
<lombok.version>1.18.22</lombok.version>
<jackson.version>2.13.1</jackson.version>
</properties>

<dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

import com.github.wasiqb.coteafs.selenium.config.ScreenshotSetting;
import com.github.wasiqb.coteafs.selenium.core.driver.IDriverActions;
import com.github.wasiqb.coteafs.selenium.core.driver.IScreenAction;
import com.google.common.truth.StringSubject;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
Expand All @@ -46,7 +45,7 @@
* @author Wasiq Bhamla
* @since 27-Jul-2019
*/
public class ScreenAction<D extends WebDriver> extends BaseDriverAction<D> implements IScreenAction, IDriverActions<D> {
public class ScreenAction<D extends WebDriver> extends BaseDriverAction<D> implements IDriverActions<D> {
private static final Logger LOG = LogManager.getLogger ();

protected static void pause (final long delay) {
Expand Down

0 comments on commit 8831a68

Please sign in to comment.