fix: stop crashing leaflet when map crashes

WatWowMap · Jan 29, 2024 · 45349be · 45349be
1 parent 728d8f0
commit 45349be
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/src/components/Container.jsx b/src/components/Container.jsx
@@ -49,8 +49,8 @@ export default function Container() {
           ref.attributionControl.setPrefix(attributionPrefix || '')
           ref.on('moveend', setLocationZoom)
           ref.on('zoomend', setLocationZoom)
-          useMapStore.setState({ map: ref })
         }
+        useMapStore.setState({ map: ref })
       }}
       zoom={zoom}
       zoomControl={false}

diff --git a/src/components/Layers.jsx b/src/components/Layers.jsx
@@ -24,7 +24,7 @@ export function ControlledZoomLayer() {
         zoom.remove()
       }
     }
-  }, [navSetting])
+  }, [navSetting, map])
 
   return null
 }
@@ -35,21 +35,25 @@ export function ControlledLocate() {
     (state) => state.settings.navigationControls === 'leaflet',
   )
 
+  const lc = React.useMemo(
+    () =>
+      control.locate({
+        position: 'bottomright',
+        icon: 'fas fa-crosshairs',
+        keepCurrentZoomLevel: true,
+        setView: 'untilPan',
+      }),
+    [],
+  )
+
   React.useEffect(() => {
     if (navSetting) {
-      const lc = control
-        .locate({
-          position: 'bottomright',
-          icon: 'fas fa-crosshairs',
-          keepCurrentZoomLevel: true,
-          setView: 'untilPan',
-        })
-        .addTo(map)
+      lc.addTo(map)
       return () => {
         lc.remove()
       }
     }
-  }, [navSetting])
+  }, [navSetting, map, lc])
 
   return null
 }