Use do { ... } while (0) to silence clang's -Wextra-semi-stmt #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First, thank you for making this code public! It is quite helpful and it is nice to have cryptographic functions implemented in a way which does not require integrating a large library.
I am using it in a project which I build with
clang
and many compiler warning files. When doing this, several warnings are emitted due to using macros as statements ending with a semicolon:Here is a Pull Request which introduces
do { ... } while (0)
constructions in the macros which are used like function calls. If you prefer silencing these warnings in another way, I am open to discussion.Thanks