Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance/multi docker test #358

Merged
merged 4 commits into from
Apr 7, 2024
Merged

enhance/multi docker test #358

merged 4 commits into from
Apr 7, 2024

Conversation

VendettaReborn
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

Previous PR(merged): #324

💡 Background and solution

to test the shadow-tls plugin for shadowsocks .etc, there are two ways:

  1. combine shadowsocks&shadow-tls binary file together, build and maintain a new one, so we can use the all-in-one image;
  2. run shadowsocks image & shadow-tls image together

the later one causes less trouble in the long term, but we need to support the running of multiple docker images at the same time.

📝 Changelog

dev: support running of multiple docker images in docker test

☑️ Self-Check before Merge

in fact, this enhancement is picked from another branch of supporting shadow-tls protocol, the test of it has been done in my ubuntu laptop.

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Changelog is provided or not needed

Copy link
Member

@ibigbug ibigbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@ibigbug ibigbug merged commit 2928780 into master Apr 7, 2024
15 checks passed
@ibigbug ibigbug deleted the feat/multi_docker_test branch April 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants