fix: sql server migration

WatheqAlshowaiter · Aug 22, 2024 · e722341 · e722341
1 parent f91b234
commit e722341
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/database/migrations/2024_07_13_090447_create_fathers_table.php b/database/migrations/2024_07_13_090447_create_fathers_table.php
@@ -33,13 +33,16 @@ public function up(): void
                 $table->string('status')->storedAs("CASE WHEN active THEN 'Active' ELSE 'Inactive' END");
             }
 
-            if ((float) App::version() >= Constants::VERSION_AFTER_STORED_AS_VIRTUAL_AS_SUPPORT && DB::getDriverName() == 'sqlsrv') {
-                $table->string('full_name')->persisted("CONCAT(first_name, ' ', last_name)");
-            }
 
             $table->timestamps(); // created_at, updated_at => ignored because they are nullable
         });
 
+        if ((float)App::version() >= Constants::VERSION_AFTER_STORED_AS_VIRTUAL_AS_SUPPORT && DB::getDriverName() == 'sqlsrv') {
+            DB::statement(/**@lang TSQL */ "
+            ALTER TABLE fathers
+            ADD full_name AS CONCAT(first_name, ' ', last_name) PERSISTED;
+        ");
+        }
     }
 
     public function down(): void

diff --git a/src/BackupTablesService.php b/src/BackupTablesService.php
@@ -102,11 +102,11 @@ function restoreTable($tableName, $backupName)
     protected function backupTablesForSqlite($newTableName, $table)
     {
         // Step 1: Create the new table structure, excluding generated columns
-        DB::statement(/**@lang SQLite* */ "CREATE TABLE $newTableName AS SELECT * FROM $table WHERE 1=0;");
+        DB::statement(/**@lang SQLite */ "CREATE TABLE $newTableName AS SELECT * FROM $table WHERE 1=0;");
 
         //$allColumns = DB::selectOne(/**@lang SQLite* */ "select * from $table");
 
-        DB::statement(/**@lang SQLite* */ "INSERT INTO $newTableName SELECT * FROM $table");
+        DB::statement(/**@lang SQLite */ "INSERT INTO $newTableName SELECT * FROM $table");
 
         $newCreatedTables[] = $newTableName;
         $response[] = " Table '$table' cloned successfully.";
@@ -121,7 +121,7 @@ protected function backupTablesForForMysqlAndMariaDb($newTableName, $table): arr
     {
         logger('mariadb');
 
-        DB::statement(/**@lang MySQL**/ "CREATE TABLE $newTableName AS SELECT * FROM $table");
+        DB::statement(/**@lang MySQL*/ "CREATE TABLE $newTableName AS SELECT * FROM $table");
 
         $newCreatedTables[] = $newTableName;
         $response[] = " Table '$table' cloned successfully.";
@@ -134,7 +134,7 @@ protected function backupTablesForForMysqlAndMariaDb($newTableName, $table): arr
 
     protected function backupTablesForForPostgres($newTableName, $table)
     {
-        DB::statement(/**@lang PostgreSQL**/ "CREATE TABLE $newTableName AS SELECT * FROM $table");
+        DB::statement(/**@lang PostgreSQL*/ "CREATE TABLE $newTableName AS SELECT * FROM $table");
 
         $newCreatedTables[] = $newTableName;
         $response[] = " Table '$table' cloned successfully.";
@@ -147,7 +147,7 @@ protected function backupTablesForForPostgres($newTableName, $table)
 
     protected function backupTablesForForSqlServer($newTableName, $table)
     {
-        DB::statement("SELECT * INTO $newTableName FROM $table");
+        DB::statement(/**@lang TSQL*/"SELECT * INTO $newTableName FROM $table");
 
         $newCreatedTables[] = $newTableName;
         $response[] = " Table '$table' cloned successfully.";