Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spec status from Draft to CR [do not merge yet!] #1764

Closed
wants to merge 3 commits into from
Closed

Conversation

rossberg
Copy link
Member

No description provided.

@dschuff
Copy link
Member

dschuff commented Aug 10, 2024

I think we are basically ready for this PR.
I tried it locally and found that the bikeshed failed to build, with this error:

FATAL ERROR: Not all required metadata was provided:
    Missing a 'Implementation Report' entry.

According to the bikeshed docs,
"Implementation Report must contain a link to an implementation report, either a hand-written document or just a link to the spec’s folder on wpt.fyi. This is required for W3C Candidate Recommendation Snapshot."

WDYT about making that a link to https://webassembly.org/features/ ? Unlike wpt.fyi it doesn't have test-level granularity and it's not automated, but its the best interoperability information that I'm aware of.

@dschuff dschuff requested a review from sideshowbarker August 10, 2024 00:26
@sideshowbarker
Copy link
Member

WDYT about making that a link to webassembly.org/features ? Unlike wpt.fyi it doesn't have test-level granularity and it's not automated, but its the best interoperability information that I'm aware of.

👍 Yes — that would absolutely be sufficient as far as satisfying the process/publication-rules requiremenents

dschuff added a commit that referenced this pull request Aug 21, 2024
This is derived from #1764 but does not actually change the publication
status by default locally or on CI (ED is the default, and the w3c echidna
publication action overrides it to WD).
It also includes a fix to the echidna Makefile rules to exit with an error
in case an underlying step returns an error.
Ms2ger pushed a commit that referenced this pull request Aug 21, 2024
This is derived from #1764 but does not actually change the publication
status by default locally or on CI (ED is the default, and the w3c echidna
publication action overrides it to WD).
It also includes a fix to the echidna Makefile rules to exit with an error
in case an underlying step returns an error.
@rossberg
Copy link
Member Author

Closing this, since it seems to have been superseded by other PRs.

@rossberg rossberg closed this Aug 29, 2024
@rossberg rossberg deleted the CR branch August 29, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants