Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content for Tut1 SDK.jl (PR required some github gynmastics) #47

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

dehann
Copy link
Contributor

@dehann dehann commented Mar 30, 2022

closes #46

@dehann dehann changed the title hacking in the content to get around some github issue Content for Tut1 SDK.jl Mar 30, 2022
@dehann dehann changed the title Content for Tut1 SDK.jl Content for Tut1 SDK.jl (PR required github gynmastics?) Mar 30, 2022
@dehann dehann requested a review from Affie March 30, 2022 06:45
@dehann
Copy link
Contributor Author

dehann commented Mar 30, 2022

Hi @Affie , can you please try this and approve PR when through.

cc @GearsAD

@dehann dehann self-assigned this Mar 30, 2022
@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

Looks like binder is also giving trouble, willl try again later:
image

@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

I get a errors local:

  • MethodError: no method matching NavAbilityHttpsClient()
  • MethodError: no method matching Variable(::String, ::Symbol)
  • UndefVarError: FullNormal not defined
  • UndefVarError: waitForCompletion not defined

@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

Ahh, it looks like we need a new release on NavAbilitySDK.jl?

@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

Ok, I checked out main on NavAbilitySDK.jl and errors above are gone, so just igone the comment.

Needs NavAbility/NavAbilitySDK.jl#86

@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

The covariance ellipse sizes in the app are not correct. I'll open an issue.

@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

Just as a general comment, do you think we should have screenshots of the app with results in the tutorails?

@Affie
Copy link
Contributor

Affie commented Mar 30, 2022

see 9d1c192

@jim-hill-r
Copy link
Contributor

The covariance ellipse sizes in the app are not correct. I'll open an issue.

Issue https://github.com/NavAbility/NavAbilityApp/issues/28

@dehann dehann changed the title Content for Tut1 SDK.jl (PR required github gynmastics?) Content for Tut1 SDK.jl (PR required some github gynmastics) Mar 30, 2022
@dehann dehann merged commit 9a8d736 into main Mar 31, 2022
@dehann dehann deleted the tut1/sdkjl/viajsonhack branch March 31, 2022 05:20
@dehann
Copy link
Contributor Author

dehann commented Mar 31, 2022

Just as a general comment, do you think we should have screenshots of the app with results in the tutorails?

Good question, however, my sense is no. Why: My understanding is we will have a static render of each tutorial already available early on, before visitors get to running code. Might be some noodling to do there to get the flow right. Either way, I do not believe it necessary to burden each of the notebooks internally with results. I want them clean, and force users to try running the code. The single static render on the way in to the tutorial seems more professional to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Tutorial 1, SDK.jl
3 participants