Retain Pinned Programs on External Volumes #1308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes note of when a pinned program is on a non-internal volume
only existing pins are added; missing pins on mounted external volumes are still removed
filter pinned, unpinned, and blocklist for existing programs only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a property to bottle pins that notes whether or not a pinned program is on an internal drive. If not, it is "removable," such that if the drive is removed, the program will not display in the Bottle Pins or Installed Programs list, but is still read from and written to the metadata plist as if it still exists. If I've covered all my bases, the user should not be able to see or interact with any hidden programs. When Whisky is next opened or refreshed when the drive is plugged in, the programs will show again. If the drive is mounted but the program is not found, it is removed like usual.
This should build on #455, except in this case a Bottle can be on an internal drive and pin programs on external ones.