-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menu bar #571
base: main
Are you sure you want to change the base?
Add menu bar #571
Conversation
I like the concept! Looks like it could be helpful |
Glad you like the concept! I can develop it further if you think it's worthwhile. I don't think it should become too bloated because it should just perform some of the most common functionality. But feel free to put any comments or suggestions in code or here where you would like to see this go, the file organization, etc when you can. So if we're in agreement, I'd like to take this further I'll have to touch some more of your written code just so the menu bar and the application stays in sync because I don't think they do right now. |
faf541d
to
ee5cf38
Compare
@cuba Rebase needed after recent reorganisation |
ee5cf38
to
79ba9e3
Compare
Done, I had to rebase it on my newer settings fixes PR so that the changes in the menu bar / in the app are in sync. Added icons to pinned items as well |
8a09e71
to
c658094
Compare
c658094
to
b4a7694
Compare
b4a7694
to
4304725
Compare
Is this commit stale? |
I think it would be really nice to add a menu bar so that we can close the Whisky window and still have its applications running or access certain useful tools.
I have created this POC for your consideration. Changes include