Skip to content

Commit

Permalink
Remove permission checks for services in the service manager
Browse files Browse the repository at this point in the history
Change-Id: I233171737b79862f3295a3f609548caf734dba62
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Ricardo Salveti de Araujo <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
  • Loading branch information
sergiusens authored and mariogrip committed Nov 2, 2015
1 parent d5990c8 commit a374a11
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions cmds/servicemanager/service_manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,12 @@ int do_add_service(struct binder_state *bs,
if (!handle || (len == 0) || (len > 127))
return -1;

if (!svc_can_register(s, len, spid)) {
ALOGE("add_service('%s',%x) uid=%d - PERMISSION DENIED\n",
str8(s, len), handle, uid);
return -1;
}
// Don't do permission checks for services in the service manager
// if (!svc_can_register(s, len, spid)) {
// ALOGE("add_service('%s',%x) uid=%d - PERMISSION DENIED\n",
// str8(s, len), handle, uid);
// return -1;
// }

si = find_svc(s, len);
if (si) {
Expand Down

0 comments on commit a374a11

Please sign in to comment.