Fix runtime errors with upgrade to [email protected] #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package.json` was fetching `2.0.0-beta.9.1` since it was the latest in terms of a semver match. Fixes breaking changes from `2.0.0-beta.8` that were keeping the starter pack from running "out of the box". Adds `yarn.lock` to prevent future dependency issues.
|
@jaxrtech Thanks for the contribution! Let's wait for @hirako2000 to merge this PR. |
|
thanks @jaxrtech for helping out. Let's add the yarn file for now. Eventually we will move to npm5 and use its (new) lock system. |
|
Thanks, sounds good! Glad to help! Yeah, it would make the sense to eventually move to the new npm lock system since the majority of devs use npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, hello! I had just ran across Whitestorm.js the other day and looks really promising.
I was trying to get started with this boilerplate/starter-kit project, but unfortunately, it wasn't working right off of the initial clone. It looks like the latest release of
[email protected]on npm made breaking changes and broke the build. (Keeping in mind the existingpackage.jsonhad^2.0.0-beta.8which will automatically match the latest^2.0.0-beta-9.1in terms of how semver matches versions using the caret).Those issues have since been resolved and
whshas been upgraded tobeta-9.1after cross-referencing examples from the framework's project.I've also added a
yarn.lockto hopefully prevent future dependency issues (given that the framework's project also includes one).Thanks!