Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @types/tapable at version ^0.2.5 #5

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

edinnen
Copy link

@edinnen edinnen commented Mar 28, 2018

The build process fails due to @types/webpack pulling @types/tapable at version 1.0.0.

As per @types/webpack's (2.2.16) package.json:

"dependencies": {
"@types/node": "*",
"@types/tapable": "*",
"@types/uglify-js": "*"
}

This results in the errors:

ERROR in [at-loader] ./node_modules/@types/webpack/index.d.ts:556:28
Type 'typeof "node_modules/@types/tapable/index"' is not a constructor function type.

ERROR in [at-loader] ./node_modules/@types/webpack/index.d.ts:598:46
Namespace '"node_modules/@types/tapable/index"' has no exported member 'Plugin'.

ERROR in [at-loader] ./node_modules/@types/webpack/index.d.ts:602:53
Namespace '"node_modules/@types/tapable/index"' has no exported member 'Plugin'.

Specifying @types/tapable to ^0.2.5 in package.json solves the issue.

@hirako2000
Copy link
Contributor

Awesome, I didn't catch that issue, thanks!

@hirako2000 hirako2000 merged commit c99b432 into WhitestormJS:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants