Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Migrate Admin Notes CRUD from Redux to RTK Query #6204

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Abishekcs
Copy link
Contributor

@Abishekcs Abishekcs commented Feb 21, 2025

What this PR does

To be Updated.

Screenshots

Before:

Before.mp4

Before Bugfix:

BEFORE.BUGFIX.mp4

After:

After.mp4

After Bugfix:

AFTER.BUGFIX.mp4

Open questions and concerns

To be Updated.

- Replaced manual Redux actions, reducers, and constants with RTK Query endpoints.
- Removed old CRUD API calls from api.js as RTK Query now handles data fetching.
- Implemented optimistic updates for create, update, and delete mutations.

This improves performance, simplifies state management, and reduces boilerplate code.
@Abishekcs Abishekcs force-pushed the redux-to-rtk-query/admin-notes branch 2 times, most recently from e36dbde to 451661f Compare February 21, 2025 09:09
…rmIgnorePatterns to support RTK Query

- Resolves Jest test failures after adding @reduxjs/toolkit Query features. Test failures were caused by nullish coalescing assignment operator (??=) which isn't supported in Node.js 14 used by CI, while tests passed locally with newer Node versions.
Old tests are no longer needed as RTK Query is now used for admin notes.
@Abishekcs Abishekcs force-pushed the redux-to-rtk-query/admin-notes branch from 1b3daea to f6d8c75 Compare February 21, 2025 15:36
@Abishekcs
Copy link
Contributor Author

Abishekcs commented Mar 3, 2025

Update: Currently writing test code for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant