-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add commit branch validation #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you have to update pnpn lock files as well ;) |
Yay!!! 🥳 📦 |
Time to manage this one :) Here are some propositions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to put an end to the observed resurgence of sloppy commit messages and branch names amongst my students -such as
git commit -m "booger aids"
or evengit checkout -b nouvelle_feature_a_gillou
-, I took it upon myself to add those validations as pre-commit hooks via Husky.Commit message validation
The expected format adheres to the Conventional Commits set of specifications. It goes as follows:
The
<type>
can befeat:
,fix:
or others likebuild:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
. The<description>
is a short message written using imperative mode (add last feature [...]
instead ofadded
for example) that effectively and accurately depicts the changes being made. The body and footers are optional and, IMHO, not necessary at this point of the training.Branch name validation
I didn't follow the
<type>/message-in-kebab-case
convention because I would like my students to create one branch per user story. The expected format goes like this:S{number}US{number}/message-in-kebab-case
(example:S3US14/fix-header
). Feel free to adapt the validation pattern as you see fit! The regex:^S\\d{1}US\\d{1,2}\/[a-z0-9]+(-[a-z0-9]+)*$
.Hope you like it!