Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check command #1

Closed
wants to merge 3 commits into from
Closed

Check command #1

wants to merge 3 commits into from

Conversation

msabramo
Copy link

Some fixes for your check command.

  • Normalize names to lowercase
  • Tell get_installed_distributions not to skip any packages like setuptools, etc.
Before
$ pip check
pdbpp 0.7.2 requires pygments, which is not installed.
bpython 0.13.1 requires pygments, which is not installed.
devpi-web 2.2.2 requires pygments, which is not installed.
distribute 0.7.3 requires setuptools, which is not installed.
Jinja2 2.7.3 requires markupsafe, which is not installed.
pyramid 1.5.2 requires setuptools, which is not installed.
pyramid 1.5.2 requires zope.deprecation, which is not installed.
waitress 0.8.9 requires setuptools, which is not installed.
zope.interface 4.1.1 requires setuptools, which is not installed.
After
$ pip check
pyramid 1.5.2 requires zope.deprecation, which is not installed.

The latter is correct in my situation because my virtualenv had Pygments and setuptools installed but not zope.deprecation.

so that we don't erroneously report packages are not installed.
Otherwise get_installed_distributions default to skipping ('setuptools',
'pip', 'python') and a lot of packages depend on setuptools.
@Wilfred
Copy link
Owner

Wilfred commented Dec 22, 2014

Thanks! Would you mind adding a test for these cases?

@msabramo
Copy link
Author

msabramo commented Mar 6, 2015

OK, I added a test but for some reason I can't get the tests to run locally and the Travis CI fails for your fork too.

I'm flying blind here, unable to test my own changes. Can you please try it and make any small mods necessary to get it working?

@msabramo
Copy link
Author

msabramo commented Mar 6, 2015

I think the problem is that your branch is quite old and needs to be rebased on origin/develop.

@Wilfred
Copy link
Owner

Wilfred commented Mar 7, 2015

Thanks for following up on this. It looks like you've sent a fixed PR anyway -- do you need anything from me?

@msabramo
Copy link
Author

msabramo commented Mar 7, 2015

Nah, I think because I sent a fixed PR, that makes it a little easier and you still get credit, because you are the original author of the commit in git.

So I think we're good.

Oh one thing you could do is review my fixed PR; the more review it gets, the better the chance of it getting merged by a committer. pypa#2492

@Wilfred Wilfred closed this Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants