Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config #6

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Improve config #6

merged 8 commits into from
Jun 18, 2024

Conversation

Vulpesx
Copy link
Contributor

@Vulpesx Vulpesx commented Jun 17, 2024

Makes the interaction with the config nicer for users.

Fix error when languages.toml doesn't exist

Remove unnecessary and also wrong language configs.
Helix default configs are good, you don't need to configure anything in most cases,
also, the configs in adn were outdated and just wrong in some cases.

Don't just append config to the file, parses languages.toml and only adds config if it doesn't already exist.
So adn doesn't override users configs.

@Wilovy09 Wilovy09 self-requested a review June 17, 2024 18:05
@Wilovy09
Copy link
Owner

Wilovy09 commented Jun 17, 2024

@Vulpesx please run cargo clippy -- -D warnings and try to fix the ones that appear, I know that some of them don't apply to you but I don't know if you did the fork when the latest version was not yet released.

I will accept it but when those clippy errors are not there.

I didn't know that with just the installation of the LSP some of them were already working by default.
I learned several things with your 2 PRs (the other one was already approved).

@Vulpesx
Copy link
Contributor Author

Vulpesx commented Jun 18, 2024

I was waiting if you would approve it before I went through the lints

@Wilovy09
Copy link
Owner

Thanks! Sorry for making you do that, but the IC throws an error when clippy detects something

@Wilovy09 Wilovy09 merged commit 31bf397 into Wilovy09:main Jun 18, 2024
11 checks passed
@Vulpesx Vulpesx mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants