-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document transformers feature #17
Conversation
README.md
Outdated
|
||
### Clone | ||
|
||
`clone` type allows the user to copy value from one fieldname to the specified fieldname with the following limitations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the original field is not removed
is the a limitation, it's by design,
maybe you can reword it to rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest commit.
README.md
Outdated
constant: { customField: 'custom-value' }, | ||
}, | ||
{ | ||
clone: { originalField: 'customField' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is confusing,
does it mean the clone
makes the previous constant
useless?
as it's overriding the customField
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed in the latest commit.
} | ||
``` | ||
|
||
## Transformers Option | ||
|
||
![image](./docs/images/transformers-workflow.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it mean the transformers have to be in the order of constant
-> clone
-> map
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point, we don't have such rules for orders, and let me redraw the picture to make it more accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, LGTM
Issues:
Status: