Add type to handle default values

WizelineLabs · Aug 1, 2019 · aa2e537 · aa2e537
1 parent b0c86dd
commit aa2e537
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 15 deletions.
diff --git a/Example/Pods/Pods.xcodeproj/project.pbxproj b/Example/Pods/Pods.xcodeproj/project.pbxproj
diff --git a/WLEmptyState/Classes/Extensions/UICollectionView+WLEmptyState.swift b/WLEmptyState/Classes/Extensions/UICollectionView+WLEmptyState.swift
@@ -61,7 +61,7 @@ extension UICollectionView: WLEmptyStateProtocol {
 
         if numberOfItems == 0 && self.subviews.count > 1 {
             originalScrollingValue = isScrollEnabled
-            isScrollEnabled = emptyStateDelegate?.emptyStateShouldScroll() ?? true
+            isScrollEnabled = emptyStateDelegate?.emptyStateShouldScroll() ?? DefaultConstants.shouldScrollOnEmptyState
 
             backgroundView = emptyStateView
             if let emptyStateView = emptyStateView as? EmptyStateView {

diff --git a/WLEmptyState/Classes/Extensions/UITableView+WLEmptyState.swift b/WLEmptyState/Classes/Extensions/UITableView+WLEmptyState.swift
@@ -62,7 +62,7 @@ extension UITableView: WLEmptyStateProtocol {
 
         if numberOfItems == 0 && self.subviews.count > 1 {
             originalScrollingValue = isScrollEnabled
-            isScrollEnabled = emptyStateDelegate?.emptyStateShouldScroll() ?? true
+            isScrollEnabled = emptyStateDelegate?.emptyStateShouldScroll() ?? DefaultConstants.shouldScrollOnEmptyState
 
             addSubview(emptyStateView)
             if let emptyStateView = emptyStateView as? EmptyStateView {

diff --git a/WLEmptyState/Classes/Misc/DefaultConstants.swift b/WLEmptyState/Classes/Misc/DefaultConstants.swift
@@ -0,0 +1,14 @@
+//
+//  DefaultConstants.swift
+//  WLEmptyState
+//
+//  Created by Jorge Ovalle on 8/1/19.
+//
+
+import Foundation
+
+enum DefaultConstants {
+
+    static let shouldScrollOnEmptyState: Bool = true
+
+}
diff --git a/WLEmptyState/Classes/Protocols/WLEmptyStateDelegate.swift b/WLEmptyState/Classes/Protocols/WLEmptyStateDelegate.swift
@@ -15,7 +15,7 @@ public protocol WLEmptyStateDelegate: class {
 public extension WLEmptyStateDelegate {
 
     func emptyStateShouldScroll() -> Bool {
-        return true
+        return DefaultConstants.shouldScrollOnEmptyState
     }
 
 }