Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/240/notify mentors #249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat/240/notify mentors #249

wants to merge 4 commits into from

Conversation

CarlosMilano
Copy link
Contributor

What does this PR do?

Notify mentors when an applicant applies to their project

Where should the reviewer start?

/app/routes/internshipProjects/$projectId/appliedproject.tsx

How should this be manually tested?

When an applicant applies to a project, it sends an email to the mentors who are in that project

Any background context you want to provide?

What are the relevant tickets?

#240

Screenshots

Captura de pantalla 2023-10-19 a la(s) 4 53 48 p m
Captura de pantalla 2023-10-19 a la(s) 7 05 17 p m

Questions

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.


Your prompt attention to this matter is greatly appreciated. If you have any questions or need further information, please don't hesitate to reach out.

Thank you for your continued support in making this project a success.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add the project's link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this. Other than that. I think is working properly

@martinrobled0
Copy link
Contributor

@jackbravo with which person we can check how we can handle the send of email ? I mean the account o services?

Copy link
Collaborator

@AxelUZ AxelUZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe later we can improve the mail interface with images and wizeline colors to keep the design line, maybe something like BambooHR mails like when someone joins Wizeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants