Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IRX load assertion #18

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix IRX load assertion #18

wants to merge 1 commit into from

Conversation

israpps
Copy link

@israpps israpps commented Nov 10, 2023

I didn't saw that the condition of the macro has a not inside it (aka, the macro expects the success condition?)

This should fix it

Enhanced IRX loader conditions

An error happened if either IRX ID is less than 0 (error reported by MODLOAD itself, eg: missing IRX dependency), or if return value is 1 (aka: module returned NO_RESIDENT_END, aka: module willingly asked to be removed from RAM )
@Wolf3s
Copy link
Owner

Wolf3s commented Nov 10, 2023

Sounds nice, the operator is on the other side after i implemented my filexio code the same was giving an error this patch should fix i will merge soon.

@israpps
Copy link
Author

israpps commented Nov 10, 2023

dont merge yet. i got confused again LOL

@Wolf3s
Copy link
Owner

Wolf3s commented Nov 10, 2023

dont merge yet. i got confused again LOL

I guessed, these operator gives false alarm sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants