-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Move ESNext to JavaScript tutorial #23725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +6.35 kB (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I like how resources for learning JavaScript in WordPress evolved.
docs/designers-developers/developers/tutorials/create-block/readme.md
Outdated
Show resolved
Hide resolved
docs/designers-developers/developers/tutorials/create-block/block-anatomy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Ziółkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a similar vein as #23593 that moved the dev environment to its own section, this PR moves the ESNext syntax out of the Create a Block tutorial to the JavaScript tutorial. This keeps all the JavaScript docs together, and we can expand on adding more examples and resources as needed.
This creates an independent resource that any tutorial or docs can link to for explaining ESNext syntax, it shouldn't be tied directly to just the Create a Block tutorial.
How has this been tested?
Confirm docs make sense, links work.
View rendered live on branch here.
Types of changes
Documentation.