Duotone: Prevent early return blocking other style generation #43300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: -3 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Good catch @aaronrobertshaw, thanks for fixing this up!
✅ Confirmed that without this change, style from #43298 are not output
✅ After removing all Duotone rules in the theme, the Image block still renders correctly
✅ With Duotone rules (and setting Duotone rules at the block level) the behaviour appears to be working as on trunk, as far as I can tell:
LGTM! ✨
aaronrobertshaw
deleted the
fix/duotone-styles-exiting-ruleset-generation-early
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes issue where a block with duotone selectors configured but no duotone declarations would exit the generation of the global styles early, blocking any other global styles for the block.
Why?
How?
Testing Instructions