test: Reduce default Jest log verbosity #53129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach of enabling the `verbose` option for all test scripts is counter to the Jest default and the Gutenberg web editor preset. This better aligns the native tests with the web tests. The `verbose` option remains enabled for "debug" scripts and can be enabled ad-hoc via the `--verbose` flag.
dcalhoun
added
[Type] Automated Testing
|
Size Change: -401 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
dcalhoun
changed the title
|
I would be in favor of this change. 👍 |
I noticed we enable the verbose mode in other cases not covered in this PR. I'm wondering if we could also disable it on them. WDYT?
|
2 tasks
Good point. I addressed this in 129929c and wordpress-mobile/gutenberg-mobile#6012. |
fluiddot
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Good point. I addressed this in 129929c and wordpress-mobile/gutenberg-mobile#6012.
Great, thanks! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
Disable the Jest
verboseoption for native tests.Why?
The current approach of enabling the
verboseoption for all testscripts diverges from the Jest default and the Gutenberg web editor
preset. This better aligns the native tests with the web tests.
The non-verbose output is helpful for comprehending results when
running many tests at once.
The
verboseoption remains enabled for "debug" scripts and canbe enabled ad-hoc via the
--verboseflag. Additionally, theverbose output remains the default output when running a single
test file.
How?
Remove the
--versboseflag andverbose: falseoption for all native testscripts aside from the debug variants, which would benefit from additional
information while debugging.
Testing Instructions
n/a
Testing Instructions for Keyboard
n/a
Screenshots or screencast