Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library modal: Try to improve checkbox labelling #58339

Merged
merged 13 commits into from
Feb 2, 2024
+27 −21
Merged

Font Library modal: Try to improve checkbox labelling #58339

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a5d497d
Revert allowing label to be false
mikachan Jan 26, 2024
c4fda88
Replace custom labels with label prop
mikachan Jan 26, 2024
ed59cd9
Try using aria-labelledby
mikachan Jan 26, 2024
5fe861b
Make FontDemo clickable
mikachan Jan 26, 2024
665ba5e
Try hiding label with CSS
mikachan Jan 26, 2024
143623d
Update components changelog
mikachan Jan 26, 2024
77407a5
Fix font library e2e test
mikachan Jan 26, 2024
9f2026b
Remove checkboxId prop
mikachan Jan 29, 2024
d53293a
Conditionally render label
mikachan Jan 31, 2024
239d4f4
Try using separate label tag
mikachan Jan 31, 2024
d417a8b
Update e2e test
mikachan Jan 31, 2024
42a2613
Update snapshot
mikachan Jan 31, 2024
d485776
Update CheckboxControl test
mikachan Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update snapshot
  • Loading branch information
@mikachan
mikachan committed Jan 31, 2024
commit 42a2613bc30f61be77bcd7d0d69708b2fe3a6241
7 changes: 1 addition & 6 deletions packages/components/src/checkbox-control/test/__snapshots__/index.tsx.snap
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ Snapshot Diff:
- First value
+ Second value

@@ -8,17 +8,31 @@
@@ -8,13 +8,27 @@
<span
class="components-checkbox-control__input-container"
>
@@ -31,11 +31,6 @@ Snapshot Diff:
/>
+ </svg>
</span>
<label
class="components-checkbox-control__label"
- for="inspector-checkbox-control-5"
+ for="inspector-checkbox-control-6"
/>
</div>
</div>
</div>