Fix horizontal flex layout in classic themes. #60154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
tellthemachines
requested review from
noisysocks,
ramonjd,
andrewserong and
t-hamano
|
Size Change: +373 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Mar 25, 2024
There was a problem hiding this comment.
I just learned that the problem reported in #60078 also occurs in the grid layout:
The selector changed in this PR only excludes flex layout, but the lower CSS specificity also solves the grid layout issue:
If we do not want to apply this margin style itself even when using the grid layout, how about updating the selector as shown below?
:where(.editor-styles-wrapper) :where(:not(.is-layout-flex):not(.is-layout-grid)) > .wp-block
Or how about simply reducing the specificity without considering any particular layout?
:where(.editor-styles-wrapper) .wp-block
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Tested in a few classic themes with all Group block manifestations. Justification works as expected in the editor (it didn't before)
| Before | After |
|---|---|
 |
 |
If we do not want to apply this margin style itself even when using the grid layout, how about updating the selector as shown below?
I also tested @t-hamano's suggestions, e.g., :where(.editor-styles-wrapper) .wp-block and they appear also to work.
|
Thanks for the reviews, folks! Good point about the grid layout @t-hamano. I'll update the selector to include it, as that will allow us to reduce layout selector specificity later. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: tellthemachines <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ramonjd <[email protected]>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: tellthemachines <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ramonjd <[email protected]>
|
This PR introduces the issue, Automattic/themes#7749 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #60078.
The selector adding auto margins to all blocks in the classic stylesheet (only enqueued for classic themes) is overly specific and targets blocks too broadly. This PR reduces the selector specificity and changes it to not apply to direct children of flex blocks.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast