Convert shortcode package to TypeScript #60526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
added
[Type] Code Quality
|
Happy to close mine :) |
|
Nice! It’s exactly what needs to happen next. We definitely need to refresh this PR. @mikeybinns, will you have time to rebase this branch with |
|
Ok, good. We definitely want to reuse all the new tests introduced in addition to other changes proposed ❤️ |
|
Okay, in that case, I will rebase it when I have time :) |
Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
* Inserter: Add 'Starter Content' category to the inserter * Add cat condition * Replace Starter Content modal with inserter panel * remove option condition * remove duplicated category * Attempt to fix media panel test * Attempt to fix style variations test * Attempt to fix recursive pattern test * Attempt to fix template resolution test * Attempt to fix new page test * Tweak template resolution test * Remove categoryObject * Fix aria-current on category tabs * Fix selected cat in patterns explorer * pass postId so that the inserter gets reopened when a new page is created using the command palette * Take control of zoom if a new page is created * Add post Id back --------- Co-authored-by: Andrei Draganescu <[email protected]> Co-authored-by: Sarah Norris <[email protected]> Co-authored-by: Ben Dwyer <[email protected]>
* Navigation: Upsize buttons * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
…canvas is zoomed out (WordPress#68106) * remove the placeholder text of and disable the default paragraph block, in zoom out mode * leave the block enabled * update the custom placeholder data attribute Co-authored-by: draganescu <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: andrewserong <[email protected]>
Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
* Navigation: Log deprecation warning * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
…68176) Co-authored-by: jsnajdr <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]>
* Inserter: Use 40px default size for toggle button * Add todo comments Co-authored-by: mirka <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
Co-authored-by: oandregal <[email protected]> Co-authored-by: louwie17 <[email protected]>
…primary` (WordPress#68168) Co-authored-by: ntsekouras <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: oandregal <[email protected]>
…8208) * Components: Normalize newlines * Clarify helper function Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
* Updated documentation order * Added Backport changelog Co-authored-by: shail-mehta <[email protected]> Co-authored-by: t-hamano <[email protected]>
Co-authored-by: t-hamano <[email protected]> Co-authored-by: ryanwelcher <[email protected]>
* Try splitting style book into sections. * Single block view * Fix classic stylebook logic * Blocks without examples should show all blocks * Update scrolling logic to always scroll to top on long pages * Scroll to top for color --------- Co-authored-by: tellthemachines <[email protected]> Co-authored-by: ramonjd <[email protected]>
Co-authored-by: kurudrive <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: luisherranz <[email protected]> Co-authored-by: ramonjd <[email protected]>
* split upload * split upload * split upload * split upload * split upload * Add missing imports for _x function --------- Co-authored-by: timse201 <[email protected]> Co-authored-by: talldan <[email protected]>
Co-authored-by: im3dabasia <[email protected]> Co-authored-by: fabiankaegy <[email protected]>
…action (WordPress#68174) * Stylebook: add the Appearance -> Design submenu through admin_menu action * Add backport reference Co-authored-by: fushar <[email protected]> Co-authored-by: ramonjd <[email protected]>
Co-authored-by: tyxla <[email protected]> Co-authored-by: mirka <[email protected]>
mikeybinns
requested review from
gziolo,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
ndiego,
luisherranz,
DAreRodz,
draganescu,
adamziel,
getdave,
dmsnell,
atimmer,
artemiomorales,
ZebulanStanphill,
michalczaplinski,
fabiankaegy,
mmtr and
juanmaguitar
as code owners
|
@gziolo Sorry, this is the second time I've made this kind of mistake, do you know what I'm doing wrong here? I tried to rebase the branch and it's said I've changed all sorts of files I haven't, and subsequently notifying basically everyone who's ever commited to WordPress :( I did a git rebase via VS Code: Sorry again everyone 😬 |
|
You should have done a trunk merge instead. |
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Converting the shortcodes package to TypeScript.
Why?
It's an enhancement, while not necessary it is helpful to reduce bugs in both the code of the package and end users code if they consume types.
How?
attrsmethod from shortcode class as it was inaccessible due to a property of the same name.attrsfunction is still exported separately as before.Testing Instructions
Covered by automatic tests.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A