Block embed: use dedicated attribute to save the embed ratio instead of using custom classes (#39616) #60895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of using custom classes (WordPress#39616)
petitphp
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
added
[Type] Enhancement
|
There could be some overlap between this PR and the new aspect ratio controls for media block - #51138. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR change the way custom CSS classes for the aspect ratio are managed for the block embed.
Why?
When a block embed is transformed to a paragraph, the custom CSS classes for the aspect ratio were not removed.
How?
This is an alternative approach of #44947. This PR go a step further by adding a new attribute to store the aspect ratio and dynamically add the aspect ratio CSS classes to the block.
Testing Instructions
classattribute should contain the classeswp-embed-aspect-16-9 wp-has-aspect-ratio