Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove term sidebar from UI side #61828

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Fix/remove term sidebar from UI side #61828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55f9709
sidebar to panel
n2erjo00 May 21, 2024
ab38cf2
Sidebar to panel term changes
n2erjo00 May 21, 2024
a88440b
Merge conflict resolved. Removed term sidepar and replaced with panel
n2erjo00 Jun 15, 2024
8a17e48
Some merge conflict non-sense. This file does not exist in trunk and …
n2erjo00 Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/editor/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,11 +884,11 @@ function MyPluginSidebar() {
return el(
PluginSidebar,
{
name: 'my-sidebar',
title: 'My sidebar title',
name: 'my-panel',
title: 'My panel title',
icon: moreIcon,
},
el( PanelBody, {}, __( 'My sidebar content' ) )
el( PanelBody, {}, __( 'My panel content' ) )
);
}
```
Expand All @@ -901,8 +901,8 @@ import { PluginSidebar } from '@wordpress/editor';
import { more } from '@wordpress/icons';

const MyPluginSidebar = () => (
<PluginSidebar name="my-sidebar" title="My sidebar title" icon={ more }>
<PanelBody>{ __( 'My sidebar content' ) }</PanelBody>
<PluginSidebar name="my-panel" title="My panel title" icon={ more }>
<PanelBody>{ __( 'My panel content' ) }</PanelBody>
</PluginSidebar>
);
```
Expand Down Expand Up @@ -932,10 +932,10 @@ function MySidebarMoreMenuItem() {
return React.createElement(
PluginSidebarMoreMenuItem,
{
target: 'my-sidebar',
target: 'my-panel',
icon: moreIcon,
},
__( 'My sidebar title' )
__( 'My panel title' )
);
}
```
Expand All @@ -947,8 +947,8 @@ import { PluginSidebarMoreMenuItem } from '@wordpress/editor';
import { more } from '@wordpress/icons';

const MySidebarMoreMenuItem = () => (
<PluginSidebarMoreMenuItem target="my-sidebar" icon={ more }>
{ __( 'My sidebar title' ) }
<PluginSidebarMoreMenuItem target="my-panel" icon={ more }>
{ __( 'My panel title' ) }
</PluginSidebarMoreMenuItem>
);
```
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/commands/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ function useEditorCommandLoader() {

commands.push( {
name: 'core/open-settings-sidebar',
label: __( 'Toggle settings sidebar' ),
label: __( 'Toggle settings panel' ),
icon: isRTL() ? drawerLeft : drawerRight,
callback: ( { close } ) => {
const activeSidebar = getActiveComplementaryArea( 'core' );
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/global-keyboard-shortcuts/register-shortcuts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function EditorKeyboardShortcutsRegister() {
registerShortcut( {
name: 'core/editor/toggle-sidebar',
category: 'global',
description: __( 'Show or hide the Settings sidebar.' ),
description: __( 'Show or hide the Settings panel.' ),
keyCombination: {
modifier: 'primaryShift',
character: ',',
Expand Down
8 changes: 4 additions & 4 deletions packages/editor/src/components/plugin-sidebar-more-menu-item/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ import { ComplementaryAreaMoreMenuItem } from '@wordpress/interface';
* return React.createElement(
* PluginSidebarMoreMenuItem,
* {
* target: 'my-sidebar',
* target: 'my-panel',
* icon: moreIcon,
* },
* __( 'My sidebar title' )
* __( 'My panel title' )
* )
* }
* ```
Expand All @@ -40,10 +40,10 @@ import { ComplementaryAreaMoreMenuItem } from '@wordpress/interface';
*
* const MySidebarMoreMenuItem = () => (
* <PluginSidebarMoreMenuItem
* target="my-sidebar"
* target="my-panel"
* icon={ more }
* >
* { __( 'My sidebar title' ) }
* { __( 'My panel title' ) }
* </PluginSidebarMoreMenuItem>
* );
* ```
Expand Down
12 changes: 6 additions & 6 deletions packages/editor/src/components/plugin-sidebar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ import { store as editorStore } from '../../store';
* return el(
* PluginSidebar,
* {
* name: 'my-sidebar',
* title: 'My sidebar title',
* name: 'my-panel',
* title: 'My panel title',
* icon: moreIcon,
* },
* el(
* PanelBody,
* {},
* __( 'My sidebar content' )
* __( 'My panel content' )
* )
* );
* }
Expand All @@ -65,12 +65,12 @@ import { store as editorStore } from '../../store';
*
* const MyPluginSidebar = () => (
* <PluginSidebar
* name="my-sidebar"
* title="My sidebar title"
* name="my-panel"
* title="My panel title"
* icon={ more }
* >
* <PanelBody>
* { __( 'My sidebar content' ) }
* { __( 'My panel content' ) }
* </PanelBody>
* </PluginSidebar>
* );
Expand Down
2 changes: 1 addition & 1 deletion post-content.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<!-- /wp:gallery -->

<!-- wp:paragraph -->
<p><?php _e( 'You can change the amount of columns in your galleries by dragging a slider in the block inspector in the sidebar.', 'gutenberg' ); ?></p>
<p><?php _e( 'You can change the amount of columns in your galleries by dragging a slider in the block settings panel.', 'gutenberg' ); ?></p>
<!-- /wp:paragraph -->

<!-- wp:heading {"level":2} -->
Expand Down
Loading