DataViews: formalize text field type definition #64168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Aug 1, 2024
|
Size Change: +39 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59745
What?
Follow suit on starting to formalize integer type definition at #64064 and #64164 this PR creates a
texttype definition with sorting and validation logic.Why?
To centralize more of our logic based on field types.
How?
Creates a new type definition (
field-types/text.tsx) and implements sorting & validation logic.Testing Instructions
Nothing to test manually. The only field that uses
texttype so far is title. However, it doesn't have any validation rules and sorting for pages/posts happens in the server (it doesn't use our filterSort utility).Verify automated tests pass.